Fix BoringSSL Windows CI targets failing with windows-latest #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DellaBitta
changed the title
DellaBitta
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
✅ Integration test succeeded!Requested by @DellaBitta on commit 8b94216 |
a-maurice
approved these changes
Jun 3, 2021
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
DellaBitta
added a commit
that referenced
this pull request
Jun 9, 2021
This change fixes the boringSSL sources so that they no longer causes warnings on windows-latest runners. Switched the boringSSL dependency to a git checkout instead of a tarball download. Created a git patch to alter boringSSL's cmake files, adding C4255 as a warning that shall be suppressed. Updated GHA configuration to use windows-latest again. This was previously changed to windows-2016 since those tools didn't report C4255 as a warning. See #444 for more information about these reverted changes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the Integration Test and Packaging workflows to use windows-2016 GHA runners.
Details:
GHA is rolling out a new version of windows server 2019 tools (windows-2019 / windows-latest alias) which produce a C4255 warning in BoringSSL.
BoringSSL is configured to error on all warnings, and so our current CI is broken until we can figure out the best way to properly patch the BorginSSL cmake configuration.